Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitignore): add .gitignore to themePropertyTables directory #397

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ImCoolNowRight
Copy link
Contributor

@ImCoolNowRight ImCoolNowRight commented Oct 31, 2023

Description

Adds a .gitignore to the themePropertyTables directory to ensure that the directory always exists, but files within it continue to be ignored.

The error, up until now, was that the directory did not exist by the time the runner attempted to write the files.

References

LUI-849

Testing

Will have to check to make sure that Actions no longer fail when trying to write color.md.

Automation

N/A

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@ImCoolNowRight ImCoolNowRight force-pushed the fix/generate-theme-props branch from 1fd1562 to 9cfa328 Compare October 31, 2023 20:38
@ImCoolNowRight ImCoolNowRight changed the title fix(ThemeTable): refactor to write file contents all at once fix(gitignore): remove themePropertyTables from .gitignore, keep files within Oct 31, 2023
@ImCoolNowRight ImCoolNowRight added the WIP In progress but could use an initial review label Oct 31, 2023
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@joshhowenstine
Copy link
Contributor

This should totally work I think. However, as an alternative we could also change line 235 to be synchronous? Honestly, ether approach is fine with me.

try { fs.mkdirSync(mdFile.substring(0, mdFile.lastIndexOf('/')), { recursive: true }); } catch (err) { if (err.code !== 'EEXIST') { throw err; } }

@ImCoolNowRight ImCoolNowRight removed the WIP In progress but could use an initial review label Nov 1, 2023
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight force-pushed the fix/generate-theme-props branch from a5ea6ba to eba486a Compare November 1, 2023 17:51
@ImCoolNowRight
Copy link
Contributor Author

This should totally work I think. However, as an alternative we could also change line 235 to be synchronous? Honestly, ether approach is fine with me.

try { fs.mkdirSync(mdFile.substring(0, mdFile.lastIndexOf('/')), { recursive: true }); } catch (err) { if (err.code !== 'EEXIST') { throw err; } }

I tried this yesterday on the IS repo. It worked fine for me locally, but continued to run into the same error on GitHub. I like keeping this (almost) empty directory around, since we know we'll always need it to exist.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight changed the title fix(gitignore): remove themePropertyTables from .gitignore, keep files within fix(gitignore): add .gitignore to themePropertyTables directory Nov 1, 2023
@ImCoolNowRight ImCoolNowRight force-pushed the fix/generate-theme-props branch from eba486a to 0ebbab1 Compare November 1, 2023 20:27
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

@ImCoolNowRight ImCoolNowRight merged commit 2004862 into develop Nov 1, 2023
5 checks passed
@ImCoolNowRight ImCoolNowRight deleted the fix/generate-theme-props branch November 1, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants