fix(FocusManager): call super in _focus and _unfocus without smoothing #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImCoolNowRight
requested review from
erautenberg,
joshhowenstine,
anthony9187,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Passed. |
joshhowenstine
approved these changes
Oct 11, 2023
anthony9187
reviewed
Oct 11, 2023
packages/@lightningjs/ui-components/src/components/Base/Base.js
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Oct 11, 2023
packages/@lightningjs/ui-components/src/components/Base/Base.js
Outdated
Show resolved
Hide resolved
ImCoolNowRight
force-pushed
the
fix/focusManager-focus
branch
from
6e19cb8 to
fcaf8e8
Compare
|
Test Execution Failed. |
1 similar comment
|
Test Execution Failed. |
ImCoolNowRight
force-pushed
the
fix/focusManager-focus
branch
from
fcaf8e8 to
561bbcd
Compare
anthony9187
approved these changes
Oct 12, 2023
|
Test Execution Failed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 12, 2023
# [@lightningjs/ui-components-v2.14.2](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.14.1...@lightningjs/ui-components-v2.14.2) (2023-10-12) ### Bug Fixes * **FocusManager:** call super in _focus and _unfocus without smoothing ([#385](#385)) ([854e891](854e891)) * **MetadataBase:** rename subtitle property, tag, and style to details ([#384](#384)) ([fdd7bfe](fdd7bfe)) * **Tile:** fix icon y position when ProgressBar is empty ([#382](#382)) ([69e3528](69e3528))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR breaks out the smooth check in
Baseinto a new method, which allows FocusManager to callsuper._focus()andsuper._unfocusto properly update as its mode changes.References
N/A
Testing
Automation
N/A
Checklist