fix(Button): allow user set heights to superceeds fallback style height

rdkcentral · Nov 6, 2023 · fc58668 · fc58668
1 parent c1d70e3
commit fc58668
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/packages/@lightningjs/ui-components/src/components/Button/Button.js b/packages/@lightningjs/ui-components/src/components/Button/Button.js
@@ -241,6 +241,14 @@ export default class Button extends Surface {
     this._Content.patch(this._contentProps);
   }
 
+  set h(v) {
+    super.h = v;
+  }
+
+  get h() {
+    return super.h || this.style.textStyle.lineHeight + this.style.paddingY * 2;
+  }
+
   _updateSurfaceDimensions() {
     let newWidth = this.w;
     if (this.fixed) {
@@ -261,10 +269,6 @@ export default class Button extends Surface {
       this.w = newWidth;
     }
 
-    this.h =
-      this.style.height ||
-      this.style.textStyle.lineHeight + this.style.paddingY * 2;
-
     // TODO breaks row resizing if this is wrapped in the above conditional
     this.fireAncestors('$itemChanged');
   }