fix(TitleRow): alias rowMarginTop to titleMarginBottom

rdkcentral · Nov 9, 2023 · aebeb94 · aebeb94
1 parent a128329
commit aebeb94
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.d.ts b/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.d.ts
@@ -34,6 +34,8 @@ type TitleRowStyle = NavigationManagerStyle & {
   w: number;
   titleMarginLeft: number;
   titleTextStyle: TextBoxStyle;
+  titleMarginBottom: number;
+  /** @deprecated */
   rowMarginTop: number;
 };
 

diff --git a/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.js b/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.js
@@ -50,6 +50,10 @@ export default class TitleRow extends Row {
     return [...super.tags, 'Title'];
   }
 
+  static get aliasStyles() {
+    return [{ prev: 'rowMarginTop', curr: 'titleMarginBottom' }];
+  }
+
   _titleLoaded() {
     this._updateRow();
   }
@@ -87,7 +91,7 @@ export default class TitleRow extends Row {
 
   _updateRow() {
     this.Items.patch({
-      y: this._Title.finalH + this.style.rowMarginTop
+      y: this._Title.finalH + this.style.titleMarginBottom
     });
   }
 

diff --git a/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.styles.js b/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.styles.js
@@ -25,7 +25,7 @@ export const base = theme => ({
     ...theme.typography.headline1,
     textColor: theme.color.textNeutral
   },
-  rowMarginTop: theme.spacer.lg
+  titleMarginBottom: theme.spacer.lg
 });
 
 export const tone = theme => ({

diff --git a/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.test.js b/packages/@lightningjs/ui-components/src/components/TitleRow/TitleRow.test.js
@@ -102,12 +102,12 @@ describe('TitleRow', () => {
           spyOnMethods: ['_titleLoaded']
         }
       );
-      expect(titleRow._Items.y).toBe(titleRow.style.rowMarginTop);
+      expect(titleRow._Items.y).toBe(titleRow.style.titleMarginBottom);
 
       await titleRow.__titleLoadedSpyPromise;
 
       expect(titleRow._Items.y).toBe(
-        titleRow._Title.finalH + titleRow.style.rowMarginTop
+        titleRow._Title.finalH + titleRow.style.titleMarginBottom
       );
     });
   });