Skip to content

Commit

Permalink
fix: update deep merge to accomidate styles for componentConfig sub p…
Browse files Browse the repository at this point in the history
…roperties
  • Loading branch information
joshhowenstine committed Nov 2, 2023
1 parent 98e7212 commit 4269305
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,14 @@ function getPropertyDescriptor(name, key) {
if (changeHandler && typeof changeHandler === 'function') {
value = changeHandler.call(this, value);
}
this[key] = key === 'style' ? clone(this[key], value) : value;
const newValue = key === 'style' ? clone(this[key], value) : value;

Check failure on line 44 in packages/@lightningjs/ui-components/src/mixins/withUpdates/index.js

View workflow job for this annotation

GitHub Actions / quality / lint-unit

Delete `········`
if (typeof this[key] === 'object' && this[key] !== null && this[key].style) {

Check failure on line 45 in packages/@lightningjs/ui-components/src/mixins/withUpdates/index.js

View workflow job for this annotation

GitHub Actions / quality / lint-unit

Replace `typeof·this[key]·===·'object'·&&·this[key]·!==·null·&&·this[key].style` with `⏎··········typeof·this[key]·===·'object'·&&⏎··········this[key]·!==·null·&&⏎··········this[key].style⏎········`
const style = clone(this[key].style, value.style || {});
newValue.style = style;
}

this[key] = newValue;
this.queueRequestUpdate();
}
},
Expand Down

0 comments on commit 4269305

Please sign in to comment.