Skip to content

Adds a new "flyweight" type - a lightweight object

Sign in for the full log view
GitHub Actions / clippy failed Dec 8, 2024 in 0s

clippy

1 error, 2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 2
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 217 in crates/common/src/var/flyweight.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync` 

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> crates/common/src/var/flyweight.rs:217:28
    |
217 |         let fl = Flyweight(Arc::new(fi));
    |                            ^^^^^^^^^^^^
    |
    = note: `Arc<Inner>` is not `Send` and `Sync` as `Inner` is neither `Send` nor `Sync`
    = help: if the `Arc` will not used be across threads replace it with an `Rc`
    = help: otherwise make `Inner` `Send` and `Sync` or consider a wrapper type such as `Mutex`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 180 in crates/common/src/var/flyweight.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync` 

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> crates/common/src/var/flyweight.rs:175:14
    |
175 |           Self(Arc::new(Inner {
    |  ______________^
176 | |             delegate,
177 | |             slots: slots.into(),
178 | |             contents,
179 | |             seal,
180 | |         }))
    | |__________^
    |
    = note: `Arc<Inner>` is not `Send` and `Sync` as `Inner` is neither `Send` nor `Sync`
    = help: if the `Arc` will not used be across threads replace it with an `Rc`
    = help: otherwise make `Inner` `Send` and `Sync` or consider a wrapper type such as `Mutex`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check failure on line 67 in crates/common/src/var/flyweight.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are deriving `Hash` but have implemented `PartialEq` explicitly 

error: you are deriving `Hash` but have implemented `PartialEq` explicitly
  --> crates/common/src/var/flyweight.rs:67:17
   |
67 | #[derive(Clone, Hash, PartialOrd, Ord, Eq)]
   |                 ^^^^
   |
note: `PartialEq` implemented here
  --> crates/common/src/var/flyweight.rs:78:1
   |
78 | impl PartialEq for Inner {
   | ^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq
   = note: `#[deny(clippy::derived_hash_with_manual_eq)]` on by default
   = note: this error originates in the derive macro `Hash` (in Nightly builds, run with -Z macro-backtrace for more info)
View more details on GitHub Actions