Initial support of listen()
clippy
4 errors, 2 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 4 |
| Warning | 2 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.82.0 (f6e511eec 2024-10-15)
- cargo 1.82.0 (8f40fc59f 2024-08-21)
- clippy 0.1.82 (f6e511e 2024-10-15)
Annotations
Check failure on line 79 in crates/console-host/src/main.rs
github-actions / clippy
non-exhaustive patterns: `Ok(rpc_common::ReplyResult::HostSuccess(_))` not covered
error[E0004]: non-exhaustive patterns: `Ok(rpc_common::ReplyResult::HostSuccess(_))` not covered
--> crates/console-host/src/main.rs:76:11
|
76 | match rpc_client.make_rpc_call(
| ___________^
77 | | client_id,
78 | | HostClientToDaemonMessage::ConnectionEstablish("console".to_string()),
79 | | ) {
| |_____^ pattern `Ok(rpc_common::ReplyResult::HostSuccess(_))` not covered
|
note: `std::result::Result<rpc_common::ReplyResult, rpc_common::RpcError>` defined here
--> /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/result.rs:527:1
::: /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/result.rs:531:5
|
= note: not covered
= note: the matched value is of type `std::result::Result<rpc_common::ReplyResult, rpc_common::RpcError>`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
|
94 ~ },
95 + Ok(rpc_common::ReplyResult::HostSuccess(_)) => todo!()
|
Check failure on line 322 in crates/console-host/src/main.rs
github-actions / clippy
this enum variant takes 5 arguments but 2 arguments were supplied
error[E0061]: this enum variant takes 5 arguments but 2 arguments were supplied
--> crates/console-host/src/main.rs:322:21
|
322 | HostClientToDaemonMessage::ClientPong(
| _____________________^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
323 | | broadcast_client_token.clone(),
324 | | SystemTime::now(),
325 | | ),
| |_____________________- three arguments of type `moor_values::Objid`, `rpc_common::HostType`, and `std::net::SocketAddr` are missing
|
note: tuple variant defined here
--> /home/runner/work/moor/moor/crates/rpc-common/src/lib.rs:134:5
|
134 | ClientPong(ClientToken, SystemTime, Objid, HostType, SocketAddr),
| ^^^^^^^^^^
help: provide the arguments
|
322 | HostClientToDaemonMessage::ClientPong(broadcast_client_token.clone(), SystemTime::now(), /* moor_values::Objid */, /* rpc_common::HostType */, /* std::net::SocketAddr */),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check failure on line 182 in crates/console-host/src/main.rs
github-actions / clippy
this enum variant takes 4 arguments but 3 arguments were supplied
error[E0061]: this enum variant takes 4 arguments but 3 arguments were supplied
--> crates/console-host/src/main.rs:182:9
|
182 | HostClientToDaemonMessage::Command(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
185 | line.to_string(),
| ---------------- argument #3 of type `moor_values::Objid` is missing
|
note: tuple variant defined here
--> /home/runner/work/moor/moor/crates/rpc-common/src/lib.rs:114:5
|
114 | Command(ClientToken, AuthToken, Objid, String),
| ^^^^^^^
help: provide the argument
|
182 | HostClientToDaemonMessage::Command(client_token.clone(), auth_token.clone(), /* moor_values::Objid */, line.to_string()),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check failure on line 108 in crates/console-host/src/main.rs
github-actions / clippy
this enum variant takes 4 arguments but 3 arguments were supplied
error[E0061]: this enum variant takes 4 arguments but 3 arguments were supplied
--> crates/console-host/src/main.rs:108:9
|
108 | HostClientToDaemonMessage::LoginCommand(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
109 | token,
110 | / vec![
111 | | "connect".to_string(),
112 | | username.to_string(),
113 | | password.to_string(),
114 | | ],
| |_____________- argument #2 of type `moor_values::Objid` is missing
|
note: tuple variant defined here
--> /home/runner/work/moor/moor/crates/rpc-common/src/lib.rs:108:5
|
108 | LoginCommand(ClientToken, Objid, Vec<String>, bool /* attach? */),
| ^^^^^^^^^^^^
help: provide the argument
|
108 ~ HostClientToDaemonMessage::LoginCommand(token, /* moor_values::Objid */, vec![
109 + "connect".to_string(),
110 + username.to_string(),
111 + password.to_string(),
112 ~ ], true),
|
Check warning on line 572 in crates/kernel/src/tasks/task.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/kernel/src/tasks/task.rs:572:6
|
572 | ) -> Result<Option<((Bytes, VerbDef), Objid)>, CommandError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 831 in crates/kernel/src/builtins/bf_server.rs
github-actions / clippy
length comparison to one
warning: length comparison to one
--> crates/kernel/src/builtins/bf_server.rs:831:8
|
831 | if bf_args.args.len() < 1 || bf_args.args.len() > 2 {
| ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bf_args.args.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default