Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: suspend() then notify() #334

Merged
merged 3 commits into from
Jun 21, 2024
Merged

test: suspend() then notify() #334

merged 3 commits into from
Jun 21, 2024

Conversation

abesto
Copy link
Collaborator

@abesto abesto commented Jun 20, 2024 •
edited
Loading

  • Expose telnet-related moot things from the moot crate
  • De-duplicate common "run this .moot file with this R: MootRunner" logic into a function
  • Re-implement the basic echo test in telnet-host as a moot test
  • Add a test for suspend() then notify(); this was previously identified as a problem case? Seems to be fine now!

@abesto abesto marked this pull request as draft June 20, 2024 21:48
@abesto
Copy link
Collaborator Author

abesto commented Jun 20, 2024

... actually, I'll pull some more goodness into execute_moot_test

@abesto abesto marked this pull request as ready for review June 20, 2024 21:52
@abesto abesto marked this pull request as draft June 20, 2024 21:56
@abesto abesto marked this pull request as ready for review June 20, 2024 22:01
@rdaum rdaum merged commit 9343530 into rdaum:main Jun 21, 2024
5 checks passed
@abesto abesto deleted the test/telnet-suspend branch June 21, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdaum rdaum rdaum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abesto @rdaum