Just some todos.

rdaum · Jan 7, 2024 · 0bfae23 · 0bfae23
1 parent 7de9a9b
commit 0bfae23
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/crates/db/src/tuplebox/base_relation.rs b/crates/db/src/tuplebox/base_relation.rs
@@ -39,6 +39,7 @@ use crate::tuplebox::RelationId;
 //   modified to support CoW/shared ownership of the tree nodes, like the im::HashMap does.
 //   if we're going to support on-disk indexes, use a CoW B+Tree, which I have implemented elsewhere,
 //   but will need to bring in here, optimize, and provide loving care to.
+// TODO: support bitmap indexes
 #[derive(Clone)]
 pub struct BaseRelation {
     pub(crate) id: RelationId,

diff --git a/crates/db/src/tuplebox/tuples/tuple_ptr.rs b/crates/db/src/tuplebox/tuples/tuple_ptr.rs
@@ -23,6 +23,8 @@ use crate::tuplebox::tuples::{SlotBox, TupleId};
 /// which allows the SlotBox to manage the lifetime of the tuple, swizzling it in and out of memory as needed.
 /// Adds a layer of indirection to each tuple access, but is better than passing around tuple ids + slotbox
 /// references.
+
+// TODO: rather than decoding a tuple out of a buffer in the slot, the slot should just hold the tuple structure
 pub struct TuplePtr {
     sb: Arc<SlotBox>,
     id: TupleId,