Skip to content

Remove react/node 'frontend' experiment for now #313

Remove react/node 'frontend' experiment for now

Remove react/node 'frontend' experiment for now #313

Triggered via push January 15, 2025 01:59
Status Success
Total duration 1m 12s
Artifacts
check_license
1m 1s
check_license
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
check_license
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
this expression creates a reference which is immediately dereferenced by the compiler: crates/node-host/src/lib.rs#L78
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/node-host/src/lib.rs:78:49 | 78 | let value = var_to_js_value(cx, &v)?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
using `clone` on type `SocketAddr` which implements the `Copy` trait: crates/node-host/src/connection.rs#L315
warning: using `clone` on type `SocketAddr` which implements the `Copy` trait --> crates/node-host/src/connection.rs:315:157 | 315 | ...oid.clone(), HostType::WebSocket, peer_addr.clone())).await; | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer_addr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Uuid` which implements the `Copy` trait: crates/node-host/src/connection.rs#L319
warning: using `clone` on type `Uuid` which implements the `Copy` trait --> crates/node-host/src/connection.rs:319:41 | 319 | Ok(event) = events_recv(client_id.clone(), &mut events_sub) => { | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `client_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
function `js_value_to_var` is never used: crates/node-host/src/lib.rs#L93
warning: function `js_value_to_var` is never used --> crates/node-host/src/lib.rs:93:4 | 93 | fn js_value_to_var<'a, C: Context<'a>>(cx: &mut C, v: Handle<'a, JsValue>) -> NeonResult<Var> { | ^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/rpc/rpc-async-client/src/lib.rs#L99
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/rpc/rpc-async-client/src/lib.rs:99:56 | 99 | match send_host_to_daemon_msg(&mut rpc_client, &host_token, host_hello).await { | ^^^^^^^^^^^ help: change this to: `host_token` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
calls to `push` immediately after creation: crates/kernel/src/builtins/bf_list_sets.rs#L353
warning: calls to `push` immediately after creation --> crates/kernel/src/builtins/bf_list_sets.rs:353:17 | 353 | / let mut match_map = vec![]; 354 | | match_map.push((v_str("match"), v_str(&target[start..end]))); 355 | | match_map.push(( 356 | | v_str("position"), 357 | | v_list(&[v_int((start as i64) + 1), v_int(end as i64)]), 358 | | )); | |___________________^ help: consider using the `vec![]` macro: `let match_map = vec![..];` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push = note: `#[warn(clippy::vec_init_then_push)]` on by default
redundant pattern matching, consider using `is_some()`: crates/kernel/src/builtins/bf_list_sets.rs#L342
warning: redundant pattern matching, consider using `is_some()` --> crates/kernel/src/builtins/bf_list_sets.rs:342:15 | 342 | while let Some(_) = regex.search_with_options( | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default help: try | 342 ~ while regex.search_with_options( 343 + target, 344 + start, 345 + end, 346 + SearchOptions::SEARCH_OPTION_NONE, 347 + Some(&mut region), 348 ~ ).is_some() { |
this expression creates a reference which is immediately dereferenced by the compiler: crates/kernel/src/builtins/bf_list_sets.rs#L337
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/kernel/src/builtins/bf_list_sets.rs:337:56 | 337 | let regex = onig::Regex::with_options(re, options, &syntax).unwrap(); | ^^^^^^^ help: change this to: `syntax` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
use of a fallible conversion when an infallible one could be used: crates/rpc/rpc-common/src/lib.rs#L330
warning: use of a fallible conversion when an infallible one could be used --> crates/rpc/rpc-common/src/lib.rs:330:28 | 330 | let pub_key: Key<32> = Key::try_from(public_key.to_bytes()) | ^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `[u8; 32]` to `Key<32>` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
use of a fallible conversion when an infallible one could be used: crates/rpc/rpc-common/src/lib.rs#L328
warning: use of a fallible conversion when an infallible one could be used --> crates/rpc/rpc-common/src/lib.rs:328:29 | 328 | let priv_key: Key<64> = Key::try_from(private_key.to_keypair_bytes()) | ^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `[u8; 64]` to `Key<64>` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: crates/common/src/var/list.rs#L233
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> crates/common/src/var/list.rs:233:1 | 233 | impl Into<Var> for List { | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<var::list::List>` | 233 ~ impl From<List> for Var { 234 ~ fn from(val: List) -> Self { 235 ~ Var::from_variant(Variant::List(val)) |