Skip to content

Some cleanups in the rpc server source structure #308

Some cleanups in the rpc server source structure

Some cleanups in the rpc server source structure #308

Triggered via push November 15, 2024 15:00
Status Success
Total duration 6m 38s
Artifacts

rust-build.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
very complex type used. Consider factoring parts into `type` definitions: crates/daemon/src/rpc_hosts.rs#L24
warning: very complex type used. Consider factoring parts into `type` definitions --> crates/daemon/src/rpc_hosts.rs:24:18 | 24 | pub struct Hosts(HashMap<HostToken, (SystemTime, HostType, Vec<(Objid, SocketAddr)>)>); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
function `verb_invoke_handler` is never used: crates/web-host/src/host/verbs.rs#L33
warning: function `verb_invoke_handler` is never used --> crates/web-host/src/host/verbs.rs:33:14 | 33 | pub async fn verb_invoke_handler( | ^^^^^^^^^^^^^^^^^^^
function `json_as_var` is never used: crates/web-host/src/host/mod.rs#L100
warning: function `json_as_var` is never used --> crates/web-host/src/host/mod.rs:100:8 | 100 | pub fn json_as_var(j: &serde_json::Value) -> Result<Var, JsonParseError> { | ^^^^^^^^^^^
variants `UnknownType`, `UnknownError`, and `InvalidRepresentation` are never constructed: crates/web-host/src/host/mod.rs#L93
warning: variants `UnknownType`, `UnknownError`, and `InvalidRepresentation` are never constructed --> crates/web-host/src/host/mod.rs:93:5 | 91 | pub enum JsonParseError { | -------------- variants in this enum 92 | #[error("Unknown type")] 93 | UnknownType, | ^^^^^^^^^^^ 94 | #[error("Unknown error")] 95 | UnknownError, | ^^^^^^^^^^^^ 96 | #[error("Invalid representation")] 97 | InvalidRepresentation, | ^^^^^^^^^^^^^^^^^^^^^ | = note: `JsonParseError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
very complex type used. Consider factoring parts into `type` definitions: crates/kernel/src/tasks/task.rs#L572
warning: very complex type used. Consider factoring parts into `type` definitions --> crates/kernel/src/tasks/task.rs:572:6 | 572 | ) -> Result<Option<((Bytes, VerbDef), Objid)>, CommandError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/