Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist announcements #1

Merged
merged 2 commits into from
Sep 29, 2019
Merged

Persist announcements #1

merged 2 commits into from
Sep 29, 2019

Conversation

rcthomas
Copy link
Owner

This allows announcements to be initialized from a previous list of persisted announcements and persist the list of announcements on update. We just use a JSON file for the storage.

  • Add configuration options for using persistent announcements
  • Add logging though it's a bit weird with traitlets
  • Change "storage" to "queue" and call it that throughout
  • Make the persisted announcement queue be the storage mechanism
  • Change template accordingly
  • Increment version number

@rcthomas rcthomas merged commit ee85608 into master Sep 29, 2019
@rcthomas rcthomas deleted the persist-announcements branch September 29, 2019 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant