Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Add _XOPEN_SOURCE macro for *BSD #40

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

rilysh
Copy link

@rilysh rilysh commented Dec 25, 2023

When building rirc on FreeBSD, I noticed some compiler warnings about a function called gettimeofday() is implicitly defined there. Even adding "sys/time.h" header, it seems like the function gettimeofday() is only visible, if __XSI_VISIBLE is defined (or simply _XOPEN_SOURCE).

GNU systems, usually avoid such macros, with _GNU_SOURCE or _DEFAULT_SOURCE macro. *BSD needs this (at least _XOPEN_SOURCE >= 600) to use this function.

Prototype definition: https://github.com/freebsd/freebsd-src/blob/13037eaabede7fb7fbc25f4e84b549c73f9acb3c/sys/sys/time.h#L631

When building rirc on FreeBSD, I noticed some compiler warnings
about a function called gettimeofday() is implicitly defined
there. Even adding "sys/time.h" header, it seems like the function
gettimeofday() is only visible, if __XSI_VISIBLE is defined (or
simply _XOPEN_SOURCE).

GNU systems, usually avoid such macros, with _GNU_SOURCE or
_DEFAULT_SOURCE macro. *BSD needs this (at least _XOPEN_SOURCE >= 600)
to use this function.

Prototype definition: https://github.com/freebsd/freebsd-src/blob/13037eaabede7fb7fbc25f4e84b549c73f9acb3c/sys/sys/time.h#L631

Signed-off-by: rilysh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant