lint: enable ineffassign and fix problems

rclone · Apr 12, 2024 · 0ef6388 · 0ef6388
1 parent 12efbbf
commit 0ef6388
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/.golangci.yml b/.golangci.yml
@@ -5,7 +5,7 @@ linters:
     #- errcheck
     - goimports
     #- revive
-    #- ineffassign
+    - ineffassign
     - govet
     #- unconvert
     #- staticcheck

diff --git a/gofakes3_test.go b/gofakes3_test.go
@@ -272,6 +272,7 @@ func TestCreateObjectWithContentDisposition(t *testing.T) {
 		Bucket: aws.String(defaultBucket),
 		Key:    aws.String("object"),
 	})
+	ts.OK(err)
 	if obj.ContentDisposition == nil {
 		t.Fatal("missing Content-Disposition")
 	}

diff --git a/s3mem/versionid.go b/s3mem/versionid.go
@@ -22,6 +22,7 @@ func newVersionGenerator(seed uint64, size int) *versionGenerator {
 	if size <= 0 {
 		size = 64
 	}
+	_ = size // FIXME size is unused here - maybe it should go into versionGenerator
 	return &versionGenerator{next: new(big.Int), state: seed}
 }