Implements throttling #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for implementing this! 👍 I was surprised that it wasn't already implemented. The Travis build failed with "dependencies": {
"limiter": "1.1.0"
} |
|
Your right! My bad, should be fixed now. |
|
Are there plans to merge this? This is great! |
|
@sleepycat As much as I'd like to keep the dependencies down to just libxmljs and needle, I would still merge this since it's such a popular feature request. @JonnyBGod As soon as tests are created I'll review the code and merge it in. Thanks. |
|
@JonnyBGod a plan for writing tests for the PR? |
|
Merge conflict is resolved here https://github.com/samogot/node-osmosis/tree/throttling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.