Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control infinite scrolling #463

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Control infinite scrolling #463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f811ad6
Control infinite scrolling
satya-imaginea Jul 8, 2021
5fd2b41
Update Lane.js
satya-imaginea Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/controllers/Lane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ class Lane extends Component {
handleScroll = evt => {
const node = evt.target
const elemScrollPosition = node.scrollHeight - node.scrollTop - node.clientHeight
const {onLaneScroll} = this.props
const {onLaneScroll, cards, totalCardsCount} = this.props
// In some browsers and/or screen sizes a decimal rest value between 0 and 1 exists, so it should be checked on < 1 instead of < 0
if (elemScrollPosition < 1 && onLaneScroll && !this.state.loading) {
if (elemScrollPosition < 10 && onLaneScroll && !this.state.loading && (!totalCardsCount || (totalCardsCount && totalCardsCount > cards.length))) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of hardcoding, we can make the loadNewRecords at position 10 become a configurable Board attribute.

const {currentPage} = this.state
this.setState({loading: true})
const nextPage = currentPage + 1
Expand Down