Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTCE v2 Fix for CTCE_Recovery #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CTCE v2 Fix for CTCE_Recovery #92

wants to merge 1 commit into from

Conversation

Peter-J-Jansen
Copy link
Contributor

The CTCE_Recovery routine, also used by command DEVINIT <CTCE_devnum>
processing, could cause a Hercules crash. This is now fixed. Additionally,
cosmetic changes were made in order to minimize diff changes when
comparing with other Hercules versions.

@Peter-J-Jansen
CTCE v2 Fix for CTCE_Recovery
4da7e92 
The CTCE_Recovery routine, also used by command DEVINIT <CTCE_devnum>
processing, could cause a Hercules crash. This is now fixed. Additionally,
cosmetic changes were made in order to minimize diff changes when
comparing with other Hercules versions.
@rbowler
Copy link
Owner

rbowler commented May 3, 2020

This change has some .vs files in it. Were these included by mistake?

@Peter-J-Jansen
Copy link
Contributor Author

I hope you are well Roger !

Yes, the .vs files were a mistake and can be deleted. I think this was caused by me using the MS VS 2019 Git / GitHub support to update my fork.

Thanks for merging these CTCE fixes (and some others). I should also update the README.NETWORKING file.

Stay healthy !

Cheers,

Peter

@rbowler
Copy link
Owner

rbowler commented Nov 7, 2020

@Peter-J-Jansen : if you could resubmit this pull request with the .vs files removed I can progress it. Thanks.

@Peter-J-Jansen
Copy link
Contributor Author

Will do Roger !

I will also remove some by now unnecessary comments to minimize diff output with the other Hercules version, and add support for the new CTCE optional ATTNDELAY parameter (developed whilst working on VTAM 3 with Bob Polmanter), and finally test it all again. This might take some time. OK ?

Cheers,

Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peter-J-Jansen @rbowler