Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xrp data feed #72

Closed
wants to merge 3 commits into from
Closed

Xrp data feed #72

wants to merge 3 commits into from

Conversation

oblo78
Copy link

@oblo78 oblo78 commented Sep 27, 2023

name: Price feed request
about: governance
title: Xrp data feed
labels:
assignees:

Description

Xrp data feed added.
I updated jobs.json and collections.json according to contributing guide.

Type of change

Please mark the options that apply to this PR.

  • New job
  • New collection
  • API is valid, example API response:
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code and it conforms with the formatting
  • I have added tests that prove my Job/Collection is valid and all tests are passing
  • I have made corresponding changes to the documentation

"selectorType": 0,
"name": "xrpbusd_binance",
"selector": "price",
"url": "https://api.binance.com/api/v3/avgPrice?symbol=XRPBUSD"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @oblo78 we will not accept any data sources that use any wrapped or pegged tokens to avoid any regulatory issues. Please remove or replace this job

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yohanelly95 i updated jobs.json replacing binance with gemini

@yohanelly95
Copy link
Member

@oblo78 I have also created this discussion here razor-network/governance#18, please add reasoning and any other information that would be useful for this governance proposal

binance remove
@yohanelly95
Copy link
Member

hey @oblo78 there seem to be some conflicts, could you rebase with upstream master branch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants