Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally caving to @o-smirnov and @bennahugo's requests. This adds an explicit feed flip term. This can be included in your
solver.terms
by selecting typefeed_flip
. Note that if you require parallactic angle correction, you should use the newly added explicitparallactic_angle
term and not theinput_model.apply_p_jones
andoutput.apply_p_jones_inv
options. The current approach will up computational complexity - I will work on improving this but it will be a big job as I will need to refactor how the gains are collapsed within the chain. That will likely be a separate future PR.Currently unanswered questions: