-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sic bugfixes #10
Sic bugfixes #10
Conversation
some values are only taken once during the hour and thus have a cnt=1 and rawdata=NA. The actual data is stored in Val, which otherwise holds the average. Since after expansion, rawdata is the main data field, the value from Val needs to be moved to rawdata in this case.
- Fix sic bugs - Slack temp range
@mlondschien this is ready for you to have a look at. I checked densities of most variables against MIMIC and HiRID and it looks good now. |
R/callback-itm.R
Outdated
@@ -213,6 +213,16 @@ mimic_age <- function(x) { | |||
|
|||
eicu_age <- function(x) as.numeric(ifelse(x == "> 89", 90, x)) | |||
|
|||
sic_sex <- function(x) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different from apply_map(
735="Female",
735="Male"))
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jup, definitely the same and simpler. That came from merging PR code from eth-mds
. Fixed it.
@mlondschien if you approve, please merge it. |
No description provided.