-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update section on rendering 📚 #99
Conversation
|
4e5163f
to
ad27254
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very much a top down (or outside-in) person when it comes to something like this. What do you think about flipping this article fully upside down (widget->frame->buffer->cell) (and then talking about the frame/terminal/backend last).
Why? Because I think it tells the person why they need to know the details before showing them that detail rather than the reverse.
225c2e3
to
263f1e4
Compare
263f1e4
to
cbc21e9
Compare
I removed the following content because I didn't know if it fit well in the description:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of comments at a very high level (there's some background discord chat on this that provides more context for anyone else reading).
Approving as it's much better than what was there and nothing in the comments is necessary to ship this.
Some general comments - there's a few sentences that start with nothing words ("basically what this", "essentially has a" and a lot of passive voice ("terminal.flush is called"). I think the ratio of code to text gets in the way of providing some good narrative info.
I think it would be worth presenting the methods from the caller's perspective rather than the ratatui code perspective (i.e. buf.set_string(...)
rather than pub fn set_string ...
)
Co-authored-by: Josh McKinney <[email protected]>
Thanks for the extremely helpful and detailed comments! I took another stab at it and pushed a new commit with a number of changes. I'm going to take a break and come back to it hopefully with a more fresh perspective. |
40371e2
to
ae8963b
Compare
ae8963b
to
4649d0f
Compare
Backends and Event Handling is last
10a9dab
to
2375314
Compare
0c8850f
to
1789368
Compare
@joshka I'm going to merge this. I'll address any additional comments you or others have in future PRs. |
No description provided.