Skip to content

Commit

Permalink
hci_h5: Don't send conf_req when ACTIVE
Browse files Browse the repository at this point in the history
Without this patch, a modem and kernel can continuously bombard each
other with conf_req and conf_rsp messages, in a demented game of tag.
  • Loading branch information
Phil Elwell authored and popcornmix committed Oct 10, 2024
1 parent 2f3eef2 commit ef6d60e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/bluetooth/hci_h5.c
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,8 @@ static void h5_handle_internal_rx(struct hci_uart *hu)
h5_link_control(hu, conf_req, 3);
} else if (memcmp(data, conf_req, 2) == 0) {
h5_link_control(hu, conf_rsp, 2);
h5_link_control(hu, conf_req, 3);
if (h5->state != H5_ACTIVE)
h5_link_control(hu, conf_req, 3);
} else if (memcmp(data, conf_rsp, 2) == 0) {
if (H5_HDR_LEN(hdr) > 2)
h5->tx_win = (data[2] & 0x07);
Expand Down

0 comments on commit ef6d60e

Please sign in to comment.