Skip to content

Commit

Permalink
input: ads7846: Add missing spi_device_id strings
Browse files Browse the repository at this point in the history
The SPI core logs error messages if a compatible string device
name is not also present as an spi_device_id.

No spi_device_id values are specified by the driver, therefore
we get 4 log lines every time it is loaded:
SPI driver ads7846 has no spi_device_id for ti,tsc2046
SPI driver ads7846 has no spi_device_id for ti,ads7843
SPI driver ads7846 has no spi_device_id for ti,ads7845
SPI driver ads7846 has no spi_device_id for ti,ads7873

Add the spi_device_id values for these devices.

Signed-off-by: Dave Stevenson <[email protected]>
  • Loading branch information
6by9 authored and pelwell committed Sep 1, 2023
1 parent fc74fc0 commit bb4e645
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions drivers/input/touchscreen/ads7846.c
Original file line number Diff line number Diff line change
Expand Up @@ -1114,6 +1114,16 @@ static const struct of_device_id ads7846_dt_ids[] = {
};
MODULE_DEVICE_TABLE(of, ads7846_dt_ids);

static const struct spi_device_id ads7846_spi_ids[] = {
{ "tsc2046", 0 },
{ "ads7843", 0 },
{ "ads7845", 0 },
{ "ads7846", 0 },
{ "ads7873", 0 },
{ }
};
MODULE_DEVICE_TABLE(spi, ads7846_spi_ids);

static const struct ads7846_platform_data *ads7846_get_props(struct device *dev)
{
struct ads7846_platform_data *pdata;
Expand Down Expand Up @@ -1390,6 +1400,7 @@ static struct spi_driver ads7846_driver = {
.pm = pm_sleep_ptr(&ads7846_pm),
.of_match_table = ads7846_dt_ids,
},
.id_table = ads7846_spi_ids,
.probe = ads7846_probe,
.remove = ads7846_remove,
};
Expand Down

0 comments on commit bb4e645

Please sign in to comment.