forked from LearnBoost/node-XMLHttpRequest
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add rest of the ssl related options supported by ws and https.request.
- Loading branch information
Tony Kovanen
committed
Oct 11, 2014
1 parent
918c00e
commit a6b6f29
Showing
1 changed file
with
11 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6b6f29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this commit merge into https://github.com/driverdan/node-XMLHttpRequest ?
engine.io-client dependency on this change.
But using github hash dependencies
"xmlhttprequest": "rase-/node-XMLHttpRequest#a6b6f2"
will be a problem fornpm install engine.io-client
in China.Normal Chinese user visit github too slow if he/she don't have a VPN or Proxy.
a6b6f29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we should publish a new module
xmlhttprequest2
instead ofxmlhttprequest
a6b6f29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xmlhttprequestcn...