✨ feat: implements async client #5
Open
+1,790
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptadev21
requested review from
pallabpain and
smrutisenapati
and removed request for
a team
guptadev21
force-pushed
the
add-async-client
branch
from
bb7e987
to
ca0d358
Compare
pallabpain
requested changes
Dec 2, 2024
| @@ -1102,10 +1113,15 @@ def create_revision( | |||
|
|
|||
| @handle_and_munchify_response | |||
| def put_keys_in_revision( | |||
| self, name: str, revision_id: str, configValues: list[(object)], **kwargs | |||
| self, name: str, revision_id: str, configValues: list[(dict)], **kwargs | |||
There was a problem hiding this comment.
Use snake case for all Python objects and variables.
Suggested change
| self, name: str, revision_id: str, configValues: list[(dict)], **kwargs | |
| self, name: str, revision_id: str, config_values: list[(dict)], **kwargs |
There was a problem hiding this comment.
@guptadev21 Check in other places also. Make it consistent.
| Args: | ||
| name (str): Config tree name | ||
| revision_id (str): Config tree revision ID | ||
| configTreeRevision (object): Config tree revision details |
There was a problem hiding this comment.
This should be config_tree_revision.
Suggested change
| configTreeRevision (object): Config tree revision details | |
| configTreeRevision (object): Config tree revision details |
pallabpain
requested changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
rapyuta_io_sdk_v2package, focusing on adding async capabilities, updating methods, and expanding test coverage. The most important changes include adding new dependencies, introducing theAsyncClient, updating method signatures, and adding async test cases.Async Client Introduction:
rapyuta_io_sdk_v2/__init__.py: ImportedAsyncClientto enable async operations in the SDK.Method Updates:
rapyuta_io_sdk_v2/client.py: Updated therefresh_tokenmethod to include an optionalset_tokenparameter and set the refreshed token in the configuration ifset_tokenisTrue. [1] [2]rapyuta_io_sdk_v2/client.py: Added missing docstrings for several methods to improve code documentation. [1] [2] [3] [4]Test Coverage:
tests/async_tests/: Added new async test casestests/utils/test_util.py: Added a fixture for initializingAsyncClientto support async test cases. [1] [2]Azure Task: Resolves AB#35883