Add new critic so we don't need path_align/use_path_orientations #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new critic is a copy-paste of PathAlignCritic but with only the part enabled by
use_path_orientations
.This allow us to fix the problem of robot not spinning to go to a path pointing backward but disabling PathAlignCritic, cause with it robot follows the path too closely
If we adopt it, better to do a proper cleanup of the uneeded parts. I keep this as draft meanwhile
Configuration
And disable
path_align
andpath_angle