Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new critic so we don't need path_align/use_path_orientations #15

Draft
wants to merge 3 commits into
base: noetic
Choose a base branch
from

Conversation

corot
Copy link
Collaborator

@corot corot commented Mar 29, 2024

The new critic is a copy-paste of PathAlignCritic but with only the part enabled by use_path_orientations.
This allow us to fix the problem of robot not spinning to go to a path pointing backward but disabling PathAlignCritic, cause with it robot follows the path too closely

If we adopt it, better to do a proper cleanup of the uneeded parts. I keep this as draft meanwhile

Configuration

  path_heading:
      enabled: true
      cost_power: 1.0
      cost_weight: 5.0
      threshold_to_consider: 0.0  # must be lower than goal distance tolerance
      offset_from_furthest: 1  # ensures robot spins in place before following the path
      trajectory_point_step: 0
      max_path_occupancy_ratio: 0.07

And disable path_align and path_angle

Base automatically changed from js/fix_critics to noetic April 1, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant