Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/material expected #96

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Fix/material expected #96

wants to merge 2 commits into from

Conversation

himanshuc3
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • [ x Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes

  • Add Assert function for Material that has color as settable.
  • If Scale is set as 0, change to a default of 0.000001 to stop warnings by THREE.js.

@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2020

This pull request introduces 1 alert when merging fe7cfa7 into 28c213a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@himanshuc3