Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RTF for 3D Livox Lidar #345

Closed
wants to merge 2 commits into from
Closed

Improve RTF for 3D Livox Lidar #345

wants to merge 2 commits into from

Conversation

arturocuma
Copy link
Contributor

Comment traceHandle on ASYNC for now, not sure if this should be removed

Copy link
Contributor

@yuokamoto yuokamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not just comment out but override in child class

@arturocuma
Copy link
Contributor Author

arturocuma commented Dec 3, 2024

you should not just comment out but override in child class

@yuokamoto it is already overwritten but it calls Super::TickComponent(DeltaTime, TickType, ThisTickFunction);
Should I inherit directly RRLiVoxMid360Component from URRBaseLidarComponent?

@yuokamoto
Copy link
Contributor

you should not just comment out but override in child class

@yuokamoto it is already overwritten but it calls Super::TickComponent(DeltaTime, TickType, ThisTickFunction); Should I inherit directly RRLiVoxMid360Component from URRBaseLidarComponent?

  1. if most of the logic is not same, you can inherit from URRBaseLidarComponent
  2. you can change it not call super Tick or call URRBaseLidarComponent::TickComponent instead of Super::TickComponent

@arturocuma
Copy link
Contributor Author

you should not just comment out but override in child class

@yuokamoto it is already overwritten but it calls Super::TickComponent(DeltaTime, TickType, ThisTickFunction); Should I inherit directly RRLiVoxMid360Component from URRBaseLidarComponent?

  1. if most of the logic is not same, you can inherit from URRBaseLidarComponent
  2. you can change it not call super Tick or call URRBaseLidarComponent::TickComponent instead of Super::TickComponent

Thanks, I will go with call URRBaseLidarComponent::TickComponent instead of Super::TickComponent

@arturocuma
Copy link
Contributor Author

We can close this PR as the changes can be done on RapyutaSimulationInternal

@arturocuma arturocuma closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants