-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add conditional rendering in scene capture logic #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto
approved these changes
Nov 25, 2024
Thank you! |
yuokamoto
pushed a commit
that referenced
this pull request
Dec 2, 2024
- Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto
pushed a commit
that referenced
this pull request
Dec 2, 2024
- Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto
pushed a commit
that referenced
this pull request
Dec 2, 2024
- Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto
pushed a commit
that referenced
this pull request
Dec 2, 2024
- Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto
pushed a commit
that referenced
this pull request
Dec 2, 2024
- Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto
added a commit
that referenced
this pull request
Dec 6, 2024
* Fix packaging character (#283) * move character to ROSAssets * add service to handle display name for editor * Update Source/RapyutaSimulationPlugins/Private/Tools/RRROS2SimulationStateClient.cpp Co-authored-by: torea Foissotte <[email protected]> --------- Co-authored-by: torea Foissotte <[email protected]> * fix world context more # Conflicts: # Content/ExternalDevices/BP_VerticalConveyor.uasset * Single order system kinematics (#288) * add single order filter to kinematic movement * Set movecomponent automatically from child BP if it is not set * Add payloadmanagement areas (#292) * Add SinkArea * create base class and make sinkarea child class of the base class * add SourceArea * add Teleport Area and change area * expose json parser to bp * update odom accesibility and fix loading order (#296) * fix loading order * update odom accesibility * make overlapsensor to point parent component instead of owner (#302) * Doc update2 (#301) * add external device, character, payload_handling_area documentation * minor utility update --------- Co-authored-by: yuokamoto <[email protected]> # Conflicts: # Content/ExternalDevices/BP_VerticalConveyor.uasset * update to make it useful for children class (#307) * fix packaging error (#311) # Conflicts: # Content/ExternalDevices/BP_VerticalConveyor.uasset * fix json initialize (#314) * add cmd_vel_timeout (#318) * Mobile rack (#317) * add mobile rack # Conflicts: # Content/ExternalDevices/BP_VerticalConveyor.uasset * Fix imu frameid (#323) * add missing frame_id to IMUComponent * Stop pub when destroyed (#326) * destroy publisher when sensor is destroyed * expose noise param * update IMU sensor, 1) acc and vel from local frame, 2) add gravity acc and acc gain * fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard (#329) * fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard * docs (RRROS2IMUComponent.cpp): add documentation about default gravity vector * feat: add conditional rendering in scene capture logic (#336) - Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering. * Spline path (#335) * add spline following mode to AIController * update document --------- Co-authored-by: torea Foissotte <[email protected]> --------- Co-authored-by: torea Foissotte <[email protected]> Co-authored-by: Paulo Rodrigues <[email protected]> Co-authored-by: Trim Bresilla <[email protected]>
yuokamoto
added a commit
that referenced
this pull request
Dec 6, 2024
* update to make it useful for children class (#307) * fix packaging error (#311) * fix json initialize (#314) * add cmd_vel_timeout (#318) * Mobile rack (#317) * add mobile rack * Fix imu frameid (#323) * add missing frame_id to IMUComponent * Stop pub when destroyed (#326) * destroy publisher when sensor is destroyed * expose noise param * update IMU sensor, 1) acc and vel from local frame, 2) add gravity acc and acc gain * fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard (#329) * fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard * docs (RRROS2IMUComponent.cpp): add documentation about default gravity vector * feat: add conditional rendering in scene capture logic (#336) - Add a `Render` bool property to control scene capture execution. - Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering. * Spline path (#335) * add spline following mode to AIController * update document --------- Co-authored-by: torea Foissotte <[email protected]> --------- Co-authored-by: Paulo Rodrigues <[email protected]> Co-authored-by: Trim Bresilla <[email protected]> Co-authored-by: torea Foissotte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small conditional rendering "check" so can be used in Blueprints to render or not render scene. When not used can be switched off so we don't need to do rendering calculations.
Render
bool property to control scene capture execution.Render
to allow for selective rendering.