Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conditional rendering in scene capture logic #336

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

bresilla
Copy link
Contributor

A very small conditional rendering "check" so can be used in Blueprints to render or not render scene. When not used can be switched off so we don't need to do rendering calculations.

  • Add a Render bool property to control scene capture execution.
  • Wrap the scene capture logic in a conditional check on Render to allow for selective rendering.

- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
@yuokamoto
Copy link
Contributor

Thank you!

@yuokamoto yuokamoto merged commit 8fbf704 into rapyuta-robotics:devel Nov 25, 2024
yuokamoto pushed a commit that referenced this pull request Dec 2, 2024
- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto pushed a commit that referenced this pull request Dec 2, 2024
- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto pushed a commit that referenced this pull request Dec 2, 2024
- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto pushed a commit that referenced this pull request Dec 2, 2024
- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto pushed a commit that referenced this pull request Dec 2, 2024
- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.
yuokamoto added a commit that referenced this pull request Dec 6, 2024
* Fix packaging character (#283)


* move character to ROSAssets

* add service to handle display name for editor

* Update Source/RapyutaSimulationPlugins/Private/Tools/RRROS2SimulationStateClient.cpp

Co-authored-by: torea Foissotte <[email protected]>

---------

Co-authored-by: torea Foissotte <[email protected]>

* fix world context more

# Conflicts:
#	Content/ExternalDevices/BP_VerticalConveyor.uasset

* Single order system kinematics (#288)

* add single order filter to kinematic movement

* Set movecomponent automatically from child BP if it is not set

* Add payloadmanagement areas (#292)

* Add SinkArea

* create base class and make sinkarea child class of the base class

* add SourceArea

* add Teleport Area and change area

* expose json parser to bp

* update odom accesibility and fix loading order (#296)

* fix loading order

* update odom accesibility

* make overlapsensor to point parent component instead of owner (#302)

* Doc update2 (#301)

* add external device, character, payload_handling_area documentation

* minor utility update
---------

Co-authored-by: yuokamoto <[email protected]>
# Conflicts:
#	Content/ExternalDevices/BP_VerticalConveyor.uasset

* update to make it useful for children class (#307)

* fix packaging error (#311)


# Conflicts:
#	Content/ExternalDevices/BP_VerticalConveyor.uasset

* fix json initialize (#314)

* add cmd_vel_timeout (#318)

* Mobile rack (#317)

* add mobile rack

# Conflicts:
#	Content/ExternalDevices/BP_VerticalConveyor.uasset

* Fix imu frameid (#323)

* add missing frame_id to IMUComponent

* Stop pub when destroyed (#326)

* destroy publisher when sensor is destroyed

* expose noise param

* update IMU sensor, 1) acc and vel from local frame, 2) add gravity acc and acc gain

* fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard (#329)

* fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard

* docs (RRROS2IMUComponent.cpp): add documentation about default gravity vector

* feat: add conditional rendering in scene capture logic (#336)

- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.

* Spline path (#335)



* add spline following mode to AIController

* update document

---------

Co-authored-by: torea Foissotte <[email protected]>

---------

Co-authored-by: torea Foissotte <[email protected]>
Co-authored-by: Paulo Rodrigues <[email protected]>
Co-authored-by: Trim Bresilla <[email protected]>
yuokamoto added a commit that referenced this pull request Dec 6, 2024
* update to make it useful for children class (#307)

* fix packaging error (#311)

* fix json initialize (#314)

* add cmd_vel_timeout (#318)

* Mobile rack (#317)

* add mobile rack

* Fix imu frameid (#323)

* add missing frame_id to IMUComponent

* Stop pub when destroyed (#326)

* destroy publisher when sensor is destroyed

* expose noise param

* update IMU sensor, 1) acc and vel from local frame, 2) add gravity acc and acc gain

* fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard (#329)

* fix (RRROS2IMUComponent.cpp): make gravity vector of IMU follow standard

* docs (RRROS2IMUComponent.cpp): add documentation about default gravity vector

* feat: add conditional rendering in scene capture logic (#336)

- Add a `Render` bool property to control scene capture execution.
- Wrap the scene capture logic in a conditional check on `Render` to allow for selective rendering.

* Spline path (#335)



* add spline following mode to AIController

* update document

---------

Co-authored-by: torea Foissotte <[email protected]>

---------

Co-authored-by: Paulo Rodrigues <[email protected]>
Co-authored-by: Trim Bresilla <[email protected]>
Co-authored-by: torea Foissotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants