Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

[RELEASE] wholegraph v24.02 #125

Merged
merged 24 commits into from
Feb 13, 2024
Merged

[RELEASE] wholegraph v24.02 #125

merged 24 commits into from
Feb 13, 2024

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-24.02 and v24.02 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-24.02 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-24.02 into main for the release

raydouglass and others added 19 commits November 9, 2023 16:34
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
…est of RAPIDS. (#112)

This PR aligns versions for wholegraph dependencies with versions used by other RAPIDS packages. This is needed for devcontainers, to make the unified RAPIDS conda environment solvable. See rapidsai/devcontainers#191.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Ray Douglass (https://github.com/raydouglass)

URL: #112
This change allows standard CMake specification of the C++ package directory (via `-Dwholegraph_ROOT`) to also work during the Python build.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)

URL: #114
Add Direct IO support option for WholeMemory loading from disk.
Using Direct IO may be faster on some high performance file systems.

Authors:
  - https://github.com/dongxuy04
  - Brad Rees (https://github.com/BradReesWork)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #113
Contributes to rapidsai/build-planning#7.

Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

### Benefits of this change

* prevents accidental inclusion of multiple `cuda-version` version in environments
* reduces update effort (via enabling more use of globs like `"12.*"`)
* improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI

### Notes for Reviewers

This change was intended to just re-organize `dependencies.yaml`, but I do think the one additional change it introduces to `all_cuda-118_arch-x86_64.yaml` is a good one. I *think* requiring the `cuda-version` metapackage in all environments is useful to prevent against environment solves that result in runtime issues.

References:

* https://github.com/conda-forge/cuda-version-feedstock/blob/902045016fbc6e4dd1350a7390b0411f376d1a19/recipe/meta.yaml#L13-L18
* https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#run-constrained

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Bradley Dice (https://github.com/bdice)

URL: #115
Reference: rapidsai/ops#2766

Replace rapids-env-update with rapids-configure-conda-channels,
rapids-configure-sccache, and rapids-date-string.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #117
fix inferencesample option

Authors:
  - Chuang Zhu (https://github.com/chuangz0)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #107
…108)

Fix a bug for embedding optimizer, it leads to undefined behavior when embedding_dim is not multiple of 32.

Authors:
  - https://github.com/linhu-nv

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #108
This PR is to address #110. 
Please feel free to comment and suggest here.

Authors:
  - Chang Liu (https://github.com/chang-l)
  - Brad Rees (https://github.com/BradReesWork)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #111
Move conda-only dependencies out of `pyproject` and `requirements` sections in `dependencies.yaml`.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Brad Rees (https://github.com/BradReesWork)

URL: #118
@raydouglass raydouglass requested a review from a team as a code owner February 2, 2024 21:40
Copy link

copy-pr-bot bot commented Feb 2, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

vyasr and others added 5 commits February 7, 2024 08:52
Add log-level-control interface in pylibwholegraph to allow user to control log level in wholememory.

Authors:
   - https://github.com/linhu-nv
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - Chuang Zhu (https://github.com/chuangz0)
Allow users to control the SMs number while gather/scatter from raw embeddings.

Authors:
   - https://github.com/linhu-nv
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - Chuang Zhu (https://github.com/chuangz0)
@raydouglass raydouglass merged commit d5c574d into main Feb 13, 2024
54 of 55 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.