Update cpplint version (#338)

This PR updates our pre-commit to use the latest version of cpplint. This brings in [my fix](cpplint/cpplint#269) that ensures that the pre-commit hook actually works in all environments. Without that fix, depending on the version of Python and setuptools in the base environment the cpplint installation may fail.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #338

.pre-commit-config.yaml

@@ -32,7 +32,7 @@ repos:
                 types_or: [file]
                 args: ['-fallback-style=none', '-style=file', '-i']
       - repo: https://github.com/cpplint/cpplint
-        rev: 1.6.1
+        rev: 2.0.0
         hooks:
               - id: cpplint
                 name: cpplint

cpp/python/src/exception.cpp

@@ -2,6 +2,7 @@
  * SPDX-FileCopyrightText: Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES.
  * SPDX-License-Identifier: BSD-3-Clause
  */
+#include <cstdio>
 #include <ios>
 #include <stdexcept>
 

cpp/python/src/worker.cpp

@@ -7,6 +7,7 @@
 #include <memory>
 #include <mutex>
 #include <sstream>
+#include <utility>
 
 #include <Python.h>
 

cpp/src/config.cpp

@@ -2,6 +2,7 @@
  * SPDX-FileCopyrightText: Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES.
  * SPDX-License-Identifier: BSD-3-Clause
  */
+#include <cstdio>
 #include <sstream>
 #include <string>
 

cpp/src/context.cpp

@@ -2,10 +2,12 @@
  * SPDX-FileCopyrightText: Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES.
  * SPDX-License-Identifier: BSD-3-Clause
  */
+#include <cstdio>
 #include <cstring>
 #include <iostream>
 #include <memory>
 #include <string>
+#include <vector>
 
 #include <ucxx/context.h>
 #include <ucxx/log.h>

cpp/src/delayed_submission.cpp

@@ -4,6 +4,7 @@
  */
 #include <memory>
 #include <mutex>
+#include <string>
 #include <utility>
 
 #include <ucp/api/ucp.h>

cpp/src/internal/request_am.cpp

@@ -8,6 +8,8 @@
 #include <ucxx/request_am.h>
 #include <ucxx/typedefs.h>
 
+#include <memory>
+
 namespace ucxx {
 
 namespace internal {

cpp/src/listener.cpp

@@ -4,6 +4,7 @@
  */
 #include <memory>
 #include <netinet/in.h>
+#include <string>
 #include <utility>
 
 #include <ucp/api/ucp.h>
@@ -42,7 +43,7 @@ Listener::Listener(std::shared_ptr<Worker> worker,
   ucxx::utils::sockaddr_get_ip_port_str(&attr.sockaddr, ipString, portString, INET6_ADDRSTRLEN);
 
   _ip   = std::string(ipString);
-  _port = (uint16_t)atoi(portString);
+  _port = static_cast<uint16_t>(atoi(portString));
 
   setParent(worker);
 }

cpp/src/memory_handle.cpp

@@ -45,7 +45,7 @@ MemoryHandle::MemoryHandle(std::shared_ptr<Context> context,
 
   utils::ucsErrorThrow(ucp_mem_query(_handle, &attr));
 
-  _baseAddress = (uint64_t)attr.address;
+  _baseAddress = reinterpret_cast<uint64_t>(attr.address);
   _size        = attr.length;
   _memoryType  = attr.mem_type;
 

cpp/src/remote_key.cpp

@@ -6,6 +6,7 @@
 #include <memory>
 #include <sstream>
 #include <string>
+#include <vector>
 
 #include <ucp/api/ucp.h>
 
@@ -84,7 +85,7 @@ std::shared_ptr<RemoteKey> createRemoteKeyFromSerialized(std::shared_ptr<Endpoin
 
 size_t RemoteKey::getSize() const { return _memorySize; }
 
-uint64_t RemoteKey::getBaseAddress() { return (uint64_t)_memoryBaseAddress; }
+uint64_t RemoteKey::getBaseAddress() { return _memoryBaseAddress; }
 
 ucp_rkey_h RemoteKey::getHandle() { return _remoteKey; }
 

cpp/src/request_am.cpp

@@ -4,9 +4,11 @@
  */
 #include <cstdio>
 #include <memory>
+#include <queue>
 #include <sstream>
 #include <stdexcept>
 #include <string>
+#include <vector>
 
 #include <ucp/api/ucp.h>
 

cpp/src/request_data.cpp

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 #include <stdexcept>
+#include <vector>
 
 #include <ucp/api/ucp.h>
 

cpp/src/request_stream.cpp

@@ -2,6 +2,7 @@
  * SPDX-FileCopyrightText: Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES.
  * SPDX-License-Identifier: BSD-3-Clause
  */
+#include <cstdio>
 #include <memory>
 #include <string>
 

cpp/src/request_tag_multi.cpp

@@ -5,6 +5,7 @@
 #include <memory>
 #include <mutex>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include <ucxx/buffer.h>

cpp/src/utils/sockaddr.cpp

@@ -3,10 +3,11 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 #include <arpa/inet.h>
+#include <cstdio>
+#include <cstring>
 #include <memory>
 #include <netdb.h>
-#include <stdlib.h>
-#include <string.h>
+#include <string>
 #include <sys/socket.h>
 
 #include <ucxx/exception.h>

cpp/src/worker.cpp

@@ -2,6 +2,7 @@
  * SPDX-FileCopyrightText: Copyright (c) 2022-2024, NVIDIA CORPORATION & AFFILIATES.
  * SPDX-License-Identifier: BSD-3-Clause
  */
+#include <cstdio>
 #include <functional>
 #include <ios>
 #include <memory>

cpp/tests/buffer.cpp

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 #include <algorithm>
+#include <memory>
 #include <numeric>
 #include <utility>
 

cpp/tests/context.cpp

@@ -4,6 +4,7 @@
  */
 #include <cstdlib>
 #include <string>
+#include <vector>
 
 #include <gtest/gtest.h>