Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make conda installs in CI stricter (part 2) #1703

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jameslamb
Copy link
Member

Description

Follow-up to #1696

Changes relative to that PR:

  • switches to pinning CI conda installs to the output of rapids-version ({major}.{minor}.{patch}) instead of rapids-version-major-minor ({major}.{minor}), to get a bit more protection in the presence of hotfix releases
  • restores some exporting of variables needed for docs builds

In #1696, I'd missed that this project's Doxygen setup is expecting to find RAPIDS_VERSION_MAJOR_MINOR defined in the environment.

doxygen Doxyfile

PROJECT_NUMBER = $(RAPIDS_VERSION_MAJOR_MINOR)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 2 - In Progress Currently a work in progress non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 10, 2024
@github-actions github-actions bot added the ci label Oct 10, 2024
@jakirkham
Copy link
Member

Thanks James! 🙏

Is anything else still needed here?

@jameslamb
Copy link
Member Author

Is anything else still needed here?

Probably not. Was just leaving it in draft to avoid bothering people with a review request until I was sure CI was passing.

@jameslamb jameslamb changed the title WIP: make conda installs in CI stricter (part 2) make conda installs in CI stricter (part 2) Oct 10, 2024
@jameslamb jameslamb removed the 2 - In Progress Currently a work in progress label Oct 10, 2024
@jameslamb jameslamb marked this pull request as ready for review October 10, 2024 18:56
@jameslamb jameslamb requested a review from a team as a code owner October 10, 2024 18:56
@jameslamb jameslamb requested a review from msarahan October 10, 2024 18:56
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 1b70ffd into rapidsai:branch-24.12 Oct 11, 2024
58 checks passed
@jameslamb jameslamb deleted the ci-conda-installs-pt2 branch October 11, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants