Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate detail::available_device_memory, most detail/aligned.hpp utilities, and optional pool_memory_resource initial size #1424

Conversation

harrism
Copy link
Member

@harrism harrism commented Jan 16, 2024

Description

Follow-on to #1417, this PR deprecates the following:

  • rmm::detail::available_device_memory in favor of rmm::available_device_memory
  • rmm::detail::is_aligned, rmm::detail::align_up and related alignment utility functions in favor of the rmm:: top level namespace versions.
  • The rmm::pool_memory_resource constructors that take an optional initial size parameter.

Should be merged after the following:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner January 16, 2024 07:25
@harrism harrism requested review from rongou and cwharris January 16, 2024 07:25
@github-actions github-actions bot added the cpp Pertains to C++ code label Jan 16, 2024
@harrism harrism added feature request New feature or request breaking Breaking change labels Jan 16, 2024
@harrism harrism self-assigned this Jan 16, 2024
@harrism harrism requested review from wence- and miscco and removed request for rongou January 16, 2024 07:26
include/rmm/aligned.hpp Outdated Show resolved Hide resolved
@harrism
Copy link
Member Author

harrism commented Jan 17, 2024

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cpp Pertains to C++ code feature request New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants