Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (#678)" #679

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Revert "Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (#678)" #679

merged 1 commit into from
Aug 20, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 20, 2024 •
edited
Loading

This reverts commit 2a80e4c.

Description

Proposes reverting #678.

See #680 for context.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@jameslamb jameslamb added bug Something isn't working non-breaking Introduces a non-breaking change labels Aug 20, 2024
@jameslamb jameslamb marked this pull request as ready for review August 20, 2024 20:31
@jameslamb jameslamb requested a review from a team as a code owner August 20, 2024 20:31
@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 82bc63b into rapidsai:branch-24.10 Aug 20, 2024
15 checks passed
@jameslamb jameslamb deleted the downgrade-cpm branch August 20, 2024 21:16
@jameslamb jameslamb mentioned this pull request Aug 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @robertmaynard @KyleFromNVIDIA