Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the latest cuco and remove outdated patches #526

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Jan 23, 2024

Description

This PR bumps to the latest cuco version which removes experimental namespace and includes multiple bug fixes.

CI must pass on these PRs before we can merge this change:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@PointKernel PointKernel marked this pull request as ready for review February 6, 2024 17:52
@PointKernel
Copy link
Member Author

This version bump includes multiple breaking changes in cuco. We want to make sure the downstream cudf, cugraph and raft PRs are ready to merge before merging this PR.

@PointKernel
Copy link
Member Author

/ok to test

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Feb 12, 2024
@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 12, 2024
@PointKernel
Copy link
Member Author

@robertmaynard This is ready to merge. Thanks!

@robertmaynard robertmaynard removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 15, 2024
@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit e3d1dfc into rapidsai:branch-24.04 Feb 15, 2024
16 checks passed
@PointKernel PointKernel deleted the cuco-experimental branch February 15, 2024 17:03
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Feb 15, 2024
Depends on rapidsai/rapids-cmake#526

CMakes changes will be reverted once rapidsai/rapids-cmake#526 is merged.

This PR updates libcudf to make it compatible with the latest cuco.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Karthikeyan (https://github.com/karthikeyann)

URL: #14849
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Feb 16, 2024
This PR updates raft to make it compatible with the latest cuco.

Depends on rapidsai/rapids-cmake#526

CMake changes will be reverted once rapidsai/rapids-cmake#526 is merged.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #2118
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Feb 17, 2024
This PR updates cugraph to make it compatible with the latest cuco.

Depends on rapidsai/rapids-cmake#526

CMake changes will be reverted once rapidsai/rapids-cmake#526 is merged.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Naim (https://github.com/naimnv)
  - Brad Rees (https://github.com/BradReesWork)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #4111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants