Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CCCL::Thrust from GLOBAL_TARGETS. #500

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 7, 2023

Description

I saw an error (below) and @robertmaynard helped me identify that this change was needed.

I was building cuGraph (this branch) with rapids-cmake pointing to this branch of cuCollections.

-- CPM: Adding package [email protected] (cccl-2.2.0)
CMake Error at build/release/_deps/rapids-cmake-src/rapids-cmake/cmake/make_global.cmake:59 (set_target_properties):
  Attempt to promote imported target "CCCL::Thrust" to global scope (by
  setting IMPORTED_GLOBAL) which is not built in this directory.
Call Stack (most recent call first):
  build/release/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:189 (rapids_cmake_make_global)
  build/release/_deps/rapids-cmake-src/rapids-cmake/cpm/cccl.cmake:85 (rapids_cpm_find)
  build/release/_deps/cuco-src/cmake/thirdparty/get_cccl.cmake:18 (rapids_cpm_cccl)
  build/release/_deps/cuco-src/cmake/thirdparty/get_cccl.cmake:21 (find_and_configure_cccl)
  build/release/_deps/cuco-src/CMakeLists.txt:79 (include)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner December 7, 2023 18:56
@bdice bdice self-assigned this Dec 7, 2023
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 7, 2023
@bdice bdice changed the title Remove Thrust from GLOBAL_TARGETS. Remove CCCL::Thrust from GLOBAL_TARGETS. Dec 7, 2023
@bdice
Copy link
Contributor Author

bdice commented Dec 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit 87aa5b2 into rapidsai:branch-24.02 Dec 8, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants