Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuco git tag #479

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

sleeepyjack
Copy link
Contributor

@sleeepyjack sleeepyjack commented Oct 19, 2023

Description

This PR updates the version of cuCollections to include a bugfix that is needed for G+H bringup.

Test PRs in downstream projects:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

CC @PointKernel

@robertmaynard
Copy link
Contributor

Thank you for creating the test PR's on other projects.

This looks good, just say when you want it merged and we will do it.

@sleeepyjack
Copy link
Contributor Author

@robertmaynard Thanks!
I just checked the Python test errors in the downstream PRs. All of them seem to be unrelated to the cuco update. If you can confirm that this is expected behavior, we can merge this PR.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 5 - Ready to Merge Testing and reviews complete, ready to merge labels Oct 20, 2023
@robertmaynard
Copy link
Contributor

@robertmaynard Thanks! I just checked the Python test errors in the downstream PRs. All of them seem to be unrelated to the cuco update. If you can confirm that this is expected behavior, we can merge this PR.

Those failures look to be related to the known arrow / aws sdk issue that the cudf team is fixing

@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit f5462bc into rapidsai:branch-23.12 Oct 20, 2023
14 checks passed
@sleeepyjack sleeepyjack deleted the update-cuco-git-tag branch October 20, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants