Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused 'joblib' and 'numba' dependencies, other packaging cleanup #2532

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Dec 17, 2024

Proposes some cleanup of packaging details, noticed while I was working on #2531

  • removes runtime dependencies on joblib and numba for raft-dask
    • raft-dask doesn't directly import from these libraries, and the git blame didn't suggest any other reason that they were being pinned here
    • *checked with git grep -E 'joblib|numba'
  • removes setup.cfg files
    • these are currently being ignored by tools, in favor of identical configuration in pyproject.toml and .flake8 files
    • e.g.
      - id: black
      files: python/.*
      # Explicitly specify the pyproject.toml at the repo root, not per-project.
      args: ["--config", "pyproject.toml"]
  • packages license files in conda packages
  • removes some outdated / inaccurate comments in packaging configs

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 17, 2024
Copy link

copy-pr-bot bot commented Dec 17, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb jameslamb added the 2 - In Progress Currenty a work in progress label Dec 17, 2024
@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: remove unused 'joblib' and 'numba' dependencies, other packaging cleanup remove unused 'joblib' and 'numba' dependencies, other packaging cleanup Dec 17, 2024
@jameslamb jameslamb removed the 2 - In Progress Currenty a work in progress label Dec 17, 2024
@jameslamb jameslamb marked this pull request as ready for review December 17, 2024 21:53
@jameslamb jameslamb requested review from a team as code owners December 17, 2024 21:53
@jameslamb jameslamb requested a review from msarahan December 17, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant