Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
non-breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jameslamb
requested review from
jameslamb
and removed request for
KyleFromNVIDIA
bdice
commented
Dec 4, 2024
| - libucxx==0.42.*,>=0.0.0a0 | ||
| - nccl>=2.19 | ||
| - spdlog>=1.14.1,<1.15 |
There was a problem hiding this comment.
spdlog was missing in RAFT conda devcontainers. Previously it was gotten transitively from RMM but that was removed in rapidsai/rmm#1739, causing a build failure. I discussed with @vyasr and we agreed this fix (adding spdlog) is necessary for the short term. In the medium-to-long term, @vyasr is going to rework the loggers.
There was a problem hiding this comment.
Thanks for summarizing that here, works for me.
(and thanks for alphabetizing this list while you're touching it).
jameslamb
approved these changes
Dec 4, 2024
|
/merge |
cjnolet
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.
See NVIDIA/cuda-python#226 (comment) for more information.