Upgrade to latest cutlass version #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
robertmaynard
requested changes
Nov 20, 2024
There was a problem hiding this comment.
We should open a PR targetting 25.02 that refactors the logic in get_cutlass to follow that used in places like: https://github.com/rapidsai/cuvs/blob/branch-24.12/cpp/cmake/thirdparty/get_hnswlib.cmake
This allows for us to not have to manually manage the patch command ( and allows us to error when the patch required fails ).
robertmaynard
approved these changes
Nov 20, 2024
|
I can't approve my own PR (even though Kyle did all the work) so @KyleFromNVIDIA can approve on my behalf if needed 😄 The changes all look good. |
cjnolet
approved these changes
Nov 21, 2024
KyleFromNVIDIA
approved these changes
Nov 21, 2024
robertmaynard
requested changes
Nov 21, 2024
There was a problem hiding this comment.
The symbol_exclusions list needs to be dropped from the rapidsai/shared-workflows/.github/workflows/[email protected] CI jobs. That will also verify this will fix the cugraph issue
robertmaynard
approved these changes
Nov 21, 2024
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Nov 22, 2024
Depends on rapidsai/raft#2503, which includes the kernel visibility fixes needed from cutlass. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #6140
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Dec 5, 2024
Due to the tight integration between cuvs and raft, we need to ensure that cuvs is updated for rapidsai/raft#2503 or builds of cuvs that rely on cloning raft will get an incompatible version of cutlass due to raft's update. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Ben Frederickson (https://github.com/benfred) URL: #516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade is important because cutlass 3.4 fixed issues with kernel visibility that would otherwise lead to global kernel symbols from raft kernels using cutlass.