Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing some left over places where implicit instantiations were being ignored in headers #2501

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
69fcde1
Rmoving bench-ann from RAFT
cjnolet Nov 15, 2024
977dbe1
Removing bench-ann from cmake
cjnolet Nov 15, 2024
739864a
Removing instantiations
cjnolet Nov 15, 2024
c039dbf
Review items
cjnolet Nov 15, 2024
37b03f2
Adding ann utils back
cjnolet Nov 15, 2024
b13eda2
Removing hnswlib stuff
cjnolet Nov 15, 2024
4328e2a
Removing get_ cmake files for ann stuff
cjnolet Nov 15, 2024
170043e
Fixing tests
cjnolet Nov 15, 2024
bcabaa3
Fixing benchmarks
cjnolet Nov 15, 2024
3747888
Removing knn tests
cjnolet Nov 15, 2024
40f3906
Remove ANN benchmarks from docs.
bdice Nov 15, 2024
63f2b4d
Remove more references in docs.
bdice Nov 15, 2024
10fd77f
Remove ANN bench from pr.yaml and get_raft.cmake template.
bdice Nov 15, 2024
af68c24
Removing neighborhood recall
cjnolet Nov 15, 2024
0a017da
Removing unused diff files
cjnolet Nov 15, 2024
21b17d6
Updating readme
cjnolet Nov 15, 2024
132ef5d
Merge branch '2412-remove-ann-bench' into 2412-remove-libraft-instant…
cjnolet Nov 15, 2024
84e552a
Adjusting docs
cjnolet Nov 15, 2024
41457df
Removing unused files from raft_intenal
cjnolet Nov 15, 2024
f06b9b2
More docs fixes
cjnolet Nov 15, 2024
129a9ad
Re-removing template project
cjnolet Nov 15, 2024
eb87ebe
Removing distance and cluster tests
cjnolet Nov 15, 2024
2878fb7
Removing notebooks
cjnolet Nov 15, 2024
9da79cf
Fixing build
cjnolet Nov 15, 2024
4b91938
Remving sparse dist tests
cjnolet Nov 15, 2024
076ad0b
Removing sparse dist tests from build.sh
cjnolet Nov 15, 2024
57b1184
Removing specializations
cjnolet Nov 15, 2024
fbb5b7c
Updating README note
cjnolet Nov 15, 2024
d557cef
Template
cjnolet Nov 15, 2024
b34d84f
Removing trustworthiness and silhouette score (these have been migrat…
cjnolet Nov 15, 2024
7e1ff0c
Removing test_hnsw from pylibraft
cjnolet Nov 15, 2024
adda5fc
Ad couple more update
cjnolet Nov 15, 2024
c4b8590
Fixing remaining python test
cjnolet Nov 15, 2024
2e3413d
Getting all pytests to pass
cjnolet Nov 15, 2024
e4e19a4
Merge branch 'branch-24.12' into 2412-remove-libraft-instantiations
cjnolet Nov 16, 2024
213a596
Missed a couple places that were still using raft compiled
cjnolet Nov 18, 2024
6496938
Removing remaining instances of implicit instantiations
cjnolet Nov 18, 2024
a29c330
Merge branch 'branch-24.12' into 2412-raft-fix_additional_instantiations
cjnolet Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 0 additions & 84 deletions cpp/include/raft/distance/fused_distance_nn-ext.cuh

This file was deleted.

8 changes: 1 addition & 7 deletions cpp/include/raft/distance/fused_distance_nn.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,4 @@
*/
#pragma once

#ifndef RAFT_EXPLICIT_INSTANTIATE_ONLY
#include "fused_distance_nn-inl.cuh"
#endif

#ifdef RAFT_COMPILED
#include "fused_distance_nn-ext.cuh"
#endif
#include "fused_distance_nn-inl.cuh"
73 changes: 0 additions & 73 deletions cpp/include/raft/linalg/detail/coalesced_reduction-ext.cuh

This file was deleted.

7 changes: 0 additions & 7 deletions cpp/include/raft/linalg/detail/coalesced_reduction.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,4 @@

#pragma once

// Always include inline definitions of coalesced reduction, because we do not
// force explicit instantion.
#include "coalesced_reduction-inl.cuh"

// Do include the extern template instantiations when possible.
#ifdef RAFT_COMPILED
#include "coalesced_reduction-ext.cuh"
#endif
Loading
Loading