Remove raft-ann-bench #2497
Merged
Remove raft-ann-bench #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
bdice
reviewed
Nov 15, 2024
|
@cjnolet I think this PR should be ready once we get CI passing. It turns out there were quite a few pieces we could prune as a result of removing raft-ann-bench. I ran devcontainer builds locally and it seems fine. I see the pip devcontainer failed, I will rerun it soon. I don't think the failure is due to these changes. I think it hit OOM during the build, which makes the job show no logs. |
benfred
approved these changes
Nov 15, 2024
|
/merge |
bdice
approved these changes
Nov 16, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Proposes some small cleanup for `dependencies.yaml` * removes `rapids_build_setuptools` dependency group - *#2497 removed the last use of `setuptools` here* * breaks `cuda-python` and `rmm` out into `depends_on_*` groups to reduce duplication, and for consistency with other RAPIDS projects ([docs explaining this](https://github.com/rapidsai/build-planning/blob/d9e3c606d95c835ee384ac6480a4af0ac6cb024a/docs/docs/packaging.md#L181)) * alphabetizes lists Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes raft-ann-bench from the conda packages, build system, and documentation. This removal was previously announced for the 24.12 release in #2448.