-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Lanczos solver v2 #2481
[FEA] Lanczos solver v2 #2481
Conversation
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
void lanczos_solver( \ | ||
const raft::resources& handle, \ | ||
raft::sparse::solver::lanczos_solver_config<ValueType> config, \ | ||
raft::device_vector_view<IndexType, uint32_t, raft::row_major> rows, \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too- please consolidate this list by using device_coo_matrix_view
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get this PR in because code freeze is looming so I'm merging this now. @lowener can we please follow-up by exposing the device_coo_matrix_view
in the public API insted of the individual arrays? It should be a 1-2 line change.
/merge |
@cjnolet I think that the name of the parameters ( |
This reverts commit 64c09d7.
I unfortunately don't have permissions to push on @aamijar branch for the previous Lanczos solver PR (#2416) so I kept his commits and continued it here.
Lanczos Solver for Sparse Eigen Decomposition
We propose a new lanczos solver in raft that fixes the issues present in the previous solver
raft::sparse::solver::detail::computeSmallestEigenvectors
.Specifically we address the following issues:
This new implementation is taken from the cupy library
cupyx.scipy.sparse.linalg.eigsh
where the thick-restart and full reorthogonalzation methods are used.Additionally this PR exposes a python api for raft lanczos solver with an interface similar to
scipy.sparse.linalg.eigsh
andcupyx.scipy.sparse.linalg.eigsh
.