-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make package installations in CI stricter #2467
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-24.12
from
jameslamb:ci-conda-installs
Oct 11, 2024
Merged
make package installations in CI stricter #2467
rapids-bot
merged 6 commits into
rapidsai:branch-24.12
from
jameslamb:ci-conda-installs
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
2 - In Progress
Currenty a work in progress
labels
Oct 8, 2024
jameslamb
changed the title
WIP: make package installations in CI stricter
make package installations in CI stricter
Oct 9, 2024
KyleFromNVIDIA
approved these changes
Oct 9, 2024
KyleFromNVIDIA
approved these changes
Oct 9, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#106
Proposes specifying the RAPIDS version in
conda install
calls in CI that install CI artifacts, to reduce the risk of CI jobs picking up artifacts from other releases.Also proposes combining together successive
pip install
calls.pip install AB
is safer thanpip install A; pip install B
becausepip
doesn't take the current set of installed packages into consideration when it installs new packages.