Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix typos in parameter tuning guide #2034

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

abc99lr
Copy link
Contributor

@abc99lr abc99lr commented Dec 1, 2023

This PR fixes the typos in the ANN benchmark parameter tuning guide regarding refine_ratio and dataset location. Specifically,

  1. Default refine ratio should be 1 instead of 0
  1. Default dataset location
  • RAFT IVF-Flat. Should be mmap instead of device. link
  • RAFT IVF-PQ. Should be host instead of device. link
  • RAFT CAGRA. Should be mmap instead of device. link

And I think we can unify the dataset location to either mmap or host. Furthermore, to enable better copy performance and enable kernel/copy overlap, RAFT should also support pinned_host as one of the memory types. I can open a separate issue for it if people think it's reasonable.

Copy link

copy-pr-bot bot commented Dec 1, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet cjnolet added documentation Improvements or additions to documentation improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search labels Dec 1, 2023
@cjnolet
Copy link
Member

cjnolet commented Dec 1, 2023

/ok to test

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @abc99lr. Please let us know if you'd like to be added to the triage group (so for example, we won't need to do ./okay to test each time you push a commit to your PR).

@cjnolet
Copy link
Member

cjnolet commented Dec 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit ecd292b into rapidsai:branch-24.02 Dec 6, 2023
62 checks passed
@abc99lr
Copy link
Contributor Author

abc99lr commented Dec 6, 2023

Thanks for the contribution @abc99lr. Please let us know if you'd like to be added to the triage group (so for example, we won't need to do ./okay to test each time you push a commit to your PR).

That would be great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search
Projects
Development

Successfully merging this pull request may close these issues.

2 participants