Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyproject versions #2002

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 16, 2023

The version doesn't need to be hardcoded into pyproject.toml files anymore, but it looks like update-version.sh wasn't updated to account for that.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Nov 16, 2023
@vyasr vyasr self-assigned this Nov 16, 2023
@vyasr vyasr requested review from a team as code owners November 16, 2023 04:20
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vyasr
Copy link
Contributor Author

vyasr commented Nov 16, 2023

/merge

@raydouglass
Copy link
Member

Going to admin merge this to get it in before the nightly run later tonight. If this is problematic, we will address it tomorrow.

@raydouglass raydouglass merged commit d67c3b2 into rapidsai:branch-24.02 Nov 16, 2023
19 checks passed
@vyasr vyasr deleted the fix/dynamic_version branch November 16, 2023 04:46
@vyasr vyasr restored the fix/dynamic_version branch November 16, 2023 04:46
@vyasr vyasr deleted the fix/dynamic_version branch November 16, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants