Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filepath in raft-ann-bench/split_groundtruth module #1911

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Fix filepath in raft-ann-bench/split_groundtruth module #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
07385df
fix path
divyegala Oct 18, 2023
d6f6417
Merge branch 'branch-23.12' into split_groundtruth_filepath
divyegala Oct 18, 2023
db79584
correct dataset name
divyegala Oct 18, 2023
5123c33
fix style
divyegala Oct 18, 2023
8b21921
fix issue with local path
divyegala Oct 18, 2023
cf8eced
chdir without filename
divyegala Oct 18, 2023
d9a62e9
use normpath
divyegala Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/raft-ann-bench/src/raft-ann-bench/run/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,14 +239,15 @@ def main():
)
conf_filename = conf_filepath.split("/")[-1]
conf_filedir = "/".join(conf_filepath.split("/")[:-1])
dataset_name = conf_filename.replace(".json", "")
dataset_path = args.dataset_path
if not os.path.exists(conf_filepath):
raise FileNotFoundError(conf_filename)

with open(conf_filepath, "r") as f:
conf_file = json.load(f)

dataset_name = conf_file["dataset"]["name"]

executables_to_run = dict()
# At least one named index should exist in config file
if args.indices:
Expand Down
10 changes: 7 additions & 3 deletions python/raft-ann-bench/src/raft-ann-bench/split_groundtruth/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,14 @@


def split_groundtruth(groundtruth_filepath):
ann_bench_scripts_path = "split_groundtruth.pl"
ann_bench_scripts_path = os.path.join(
os.path.dirname(os.path.realpath(__file__)), "split_groundtruth.pl"
)
pwd = os.getcwd()
os.chdir("/".join(groundtruth_filepath.split("/")[:-1]))
groundtruth_filename = groundtruth_filepath.split("/")[-1]
path_to_groundtruth = os.path.normpath(groundtruth_filepath).split(os.sep)
if len(path_to_groundtruth) > 1:
os.chdir(os.path.join(*path_to_groundtruth[:-1]))
groundtruth_filename = path_to_groundtruth[-1]
subprocess.run(
[ann_bench_scripts_path, groundtruth_filename, "groundtruth"],
check=True,
Expand Down