Build fix for CUDA 12.2 #1870
Merged
Build fix for CUDA 12.2 #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on cuda 12.2 shows errors like
```
/code/raft/cpp/include/raft/spatial/knn/detail/ball_cover/registers-inl.cuh(177): error #20054-D: dynamic initialization is not supported for a function-scope static __shared__ variable within a __device__/__global__ function
KeyValuePair<value_t, value_idx> shared_memV[kNumWarps * warp_q];
```
Fix by using default constructors for structures in shared memory, even trivial constructors
will cause this issue
cjnolet
approved these changes
Oct 5, 2023
|
/merge |
divyegala
pushed a commit
to divyegala/raft
that referenced
this pull request
Oct 6, 2023
Building on cuda 12.2 shows errors like
```
/code/raft/cpp/include/raft/spatial/knn/detail/ball_cover/registers-inl.cuh(177): error #20054-D: dynamic initialization is not supported for a function-scope static __shared__ variable within a __device__/__global__ function
KeyValuePair<value_t, value_idx> shared_memV[kNumWarps * warp_q];
```
Fix by using default constructors for structures in shared memory, even trivial constructors will cause this issue
Authors:
- Ben Frederickson (https://github.com/benfred)
- Corey J. Nolet (https://github.com/cjnolet)
Approvers:
- Corey J. Nolet (https://github.com/cjnolet)
URL: rapidsai#1870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on cuda 12.2 shows errors like
Fix by using default constructors for structures in shared memory, even trivial constructors will cause this issue