Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-23.10 to branch-23.12 #1852

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-23.10 that creates a PR to keep branch-23.12 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

- [x] Build Time comparison of end-to-end RAFT CAGRA+nn-descent against cuANN CAGRA+nn-descent
- [x] Recall comparison of RAFT nn-descent against cuANN nn-descent
- [x] RAFT types/APIs in ported code from cuANN
- [x] End-to-end CAGRA+nn-descent tests
- [x] Docs and code examples
- [x] Add `graph_build_algo` build param to CAGRA ann-bench for benchmarking builds with IVF-PQ or NN-Descent
- [x] All-neighbors knn graph nn-descent tests against brute-force knn

Recall Value comparison of RAFT nn-descent vs cuANN nn-descent
```
Dataset	graph_degree, intermediate_degree	Iterations	cuANN Recall	RAFT Recall
sift-128-euclidean	(64, 98)	            15	        0.9265991875	0.9471194688
sift-128-euclidean	(64, 98)	            50	        0.9831858594	0.9783938594
deep-image-96-inner	(64, 98)	            50	        0.9806211946	0.9801508853
```

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Ray Wang (https://github.com/RayWang96)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Ray Wang (https://github.com/RayWang96)
  - Ray Douglass (https://github.com/raydouglass)
  - Tamas Bela Feher (https://github.com/tfeher)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1748
@GPUtester GPUtester requested review from a team as code owners September 26, 2023 06:16
@GPUtester GPUtester merged commit 179e528 into branch-23.12 Sep 26, 2023
17 checks passed
@GPUtester
Copy link
Contributor Author

SUCCESS - forward-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants