Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft-ann-bench package fixes for plotting and conf files #1844

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Sep 22, 2023

Number of improvements and fixes for different million scale datasets that are supported by default by the python benchmarking package.

@dantegd dantegd requested a review from a team as a code owner September 22, 2023 18:54
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change and removed python labels Sep 22, 2023
{"ef":600, "numThreads":1},
{"ef":800, "numThreads":1}
],
"search_result_file" : "result/nytimes-256-inner/hnswlib/M12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key is not needed anymore, it was necessary in the old benchmarks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have it in a lot of files, perhaps I can do a follow up to remove it everywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please!

@dantegd dantegd changed the title raft-ann-bench package conf file fixes and improvements raft-ann-bench package fixes for plotting and conf files Sep 22, 2023
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending successful local runs

@dantegd
Copy link
Member Author

dantegd commented Sep 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit ba923cc into rapidsai:branch-23.10 Sep 25, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants